2020-04-29 02:08:59 UTC - Ning yougang: @Rodric Rabbah, good morning, are you there? https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588126139174900 ---- 2020-04-29 02:14:44 UTC - Rodric Rabbah: always rolling_on_the_floor_laughing : Kostis Kaffes https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588126484175200 ---- 2020-04-29 02:14:54 UTC - Rodric Rabbah: what’s up https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588126494175400 ---- 2020-04-29 02:25:11 UTC - Ning yougang: Ah, ok https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588127111175700 ---- 2020-04-29 02:25:29 UTC - Ning yougang: Regading <https://github.com/apache/openwhisk/pull/4871> https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588127129175900 ---- 2020-04-29 02:25:50 UTC - Ning yougang: You suggest `Change the manifest reader to check for the new field name and failing that look for the old field` https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588127150176200 ---- 2020-04-29 02:26:17 UTC - Ning yougang: During implement, how about keep `initialCount` and `count` exist both in `runtimes.json` and `StemCell.class` and `PrewarmingConfig.class`? Next time, can remove the field `count` https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588127177176700 ---- 2020-04-29 02:31:45 UTC - Rodric Rabbah: i didn’t look too carefully at the implementation - the types and fields used in the classes are orthogonal to what the fields are named in the json file https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588127505181100 ---- 2020-04-29 02:31:57 UTC - Ning yougang: if use ``get(initialCount).orElse(count)`` , actually is `initialCount.getOrElse(count)`, it seems `initialCount` is ``Option[Int]``, but count is `Int` , i just feel it is a little strange because count and initialCount are parallel but have different data structure define. https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588127517181600 ---- 2020-04-29 02:33:55 UTC - Rodric Rabbah: is the json read with a default JSON deserializer? i dont remember https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588127635182300 ---- 2020-04-29 02:34:33 UTC - Rodric Rabbah: looks like it is - you’re using the jsonFormat - right? https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588127673182800 ---- 2020-04-29 02:35:30 UTC - Ning yougang: `protected[core] def initialize(config: WhiskConfig, manifestOverride: Option[String] = None): Try[Runtimes] = {` `val rmc = loadConfigOrThrow[RuntimeManifestConfig](ConfigKeys.runtimes)` `val mf = Try(manifestOverride.getOrElse(config.runtimesManifest).parseJson.asJsObject).flatMap(runtimes(_, rmc))` `mf.foreach(m => manifest = Some(m))` `mf` `}` https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588127730184300 ---- 2020-04-29 02:36:20 UTC - Ning yougang: Convert json -> Runtimes in above codes. https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588127780184900 ---- 2020-04-29 02:37:43 UTC - Rodric Rabbah: youd have to define a custom deserializer https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588127863186400 ---- 2020-04-29 02:37:52 UTC - Rodric Rabbah: for StemCell class https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588127872186600 ---- 2020-04-29 02:40:08 UTC - Rodric Rabbah: something like ```val serdes = new RootJsonFormat[StemCell] { val defaultSerdes = jsonFormat3(StemCell) override def read(v: JsValue) { val initialCount = v.asJsObject.fields.get("initialCount").orElse("count").getOrElse(1) ... }
override def write(s: StemCell) = defaultSerdes.write(s) }``` https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588128008188100 ---- 2020-04-29 02:40:40 UTC - Ning yougang: Ah, ok, thanks, i will try ^^ https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588128040188600 ---- 2020-04-29 02:41:47 UTC - Rodric Rabbah: amended for the writer - i did this in slack no promise it compiles but gives you the general idea https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588128107189400 ---- 2020-04-29 02:42:44 UTC - Ning yougang: ok https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588128164189700 ---- 2020-04-29 05:16:34 UTC - Ning yougang: @Rodric Rabbah,already modify like you said +1 : Rodric Rabbah https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588137394190100 ---- 2020-04-29 14:32:02 UTC - Rodric Rabbah: sorry about the zoombombing - we thought we’d be ok without a password since our link isn’t public but apparently not these days https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588170722191000 ---- 2020-04-29 14:32:33 UTC - Rodric Rabbah: Matt has set a password - shall we restart? https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588170753192100 ---- 2020-04-29 14:32:44 UTC - mbl: could you share the password Rodric? https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588170764192400 ---- 2020-04-29 14:32:54 UTC - Rodric Rabbah: `apache` https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588170774192700 ---- 2020-04-29 14:32:58 UTC - mbl: thx https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588170778192900 ---- 2020-04-29 14:33:05 UTC - Rodric Rabbah: presumably bad actors are not in our slack https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588170785193200 ---- 2020-04-29 15:07:03 UTC - Rodric Rabbah: thanks everyone for joining and sorry for the zoom bombing - we’ll have to figure out how to secure the call for the future +1 : mbl https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588172823194500 ---- 2020-04-29 21:27:12 UTC - Lixiang Ao: hi community. is there any docs on configuring prewarm/stem cells? I can’t find any in the github repo or <http://apache.org/documentation|apache.org/documentation> https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588195632196400 ---- 2020-04-29 21:36:28 UTC - Rodric Rabbah: hello @Lixiang Ao might not have it properly documented take a look here <https://github.com/apache/openwhisk/blob/154faf985262f4fd0e06ca55b0fc96b6e37c3965/ansible/files/runtimes.json#L58-L63> +1 : Lixiang Ao https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588196188196900 ---- 2020-04-29 21:37:17 UTC - Rodric Rabbah: and in code <https://github.com/apache/openwhisk/blob/bae8fb6e5b12e38b06c28a067567df6b0701b453/common/scala/src/main/scala/org/apache/openwhisk/core/entity/ExecManifest.scala#L136-L143> https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1588196237197200 ----
