Thanks Dominic, I reviewed the PR and left a minor question. LGTM.
On Sun, Feb 25, 2024 at 1:18 AM Dominic Kim <style9...@gmail.com> wrote: > Now the main PR [1] has passed all CI tests and it has been approved. > Any comments would be appreciated. > Since it's a kind of breaking change, I would wait for several days before > merging it. > > Best regards > Dominic > > [1] https://github.com/apache/openwhisk/pull/5463 > > > 2024년 2월 19일 (월) 오전 8:15, Dominic Kim <style9...@gmail.com>님이 작성: > > > I am still working on making ci tests work. > > I think we need similar changes in the openwhisk-deploy-kube repo to > > enable the scheduler by default. > > Could anyone address this part in the meantime? > > > > I appreciate your help. > > > > Best regards > > Dominic. > > > > > > 2024년 2월 17일 (토) 오전 12:03, Dave Grove <dgr...@apache.org>님이 작성: > > > >> Sounds great! > >> > >> I agree we should go to 2.0.0 and that we should make the new scheduler > >> the default. > >> > >> --Dave > >> > >> On 2024/02/11 01:03:26 Dominic Kim wrote: > >> > Dear whiskers. > >> > > >> > Since we released the first official OpenWhisk Core 1.0.0 in 2020, > it's > >> > been around 3 years since we didn't release the subsequent version. > >> > We need to discuss whether the version should be 2.0.0, but I believe > >> this > >> > is the right time to release a new version. > >> > > >> > I am thinking of enabling the new scheduler by default before > releasing > >> the > >> > new version. > >> > So I am considering using 2.0.0 as the new version number because > there > >> are > >> > fundamental changes. > >> > > >> > Please let me know if you want to use another version number and if > any > >> PRs > >> > should be merged before releasing the new version of OpenWhisk Core. > >> > Currently, the following PRs are in my mind. > >> > > >> > - Upgrade the docker version to 23.0.6 [1] > >> > - Enable multiple controllers [2] > >> > - Add test cases that guarantee the main execution flows of > >> FPCScheduler [3] > >> > - (not opened yet) Enable the scheduler by default > >> > > >> > [1] https://github.com/apache/openwhisk/pull/5436 > >> > [2] https://github.com/apache/openwhisk/pull/5420 > >> > [3] https://github.com/apache/openwhisk/pull/5308 > >> > > >> > Best regards > >> > Dominic > >> > > >> > > >
