[ 
https://issues.apache.org/jira/browse/OPTIQ-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055400#comment-14055400
 ] 

Vladimir Sitnikov commented on OPTIQ-296:
-----------------------------------------

{quote}it seems that the vast majority of changes are renames ('git mv'). 
{quote}
Git does not rely on {{git mv}} to detect renames. It just compares the content 
and understands that the file was moved no matter how do do the rename.

{quote}3. Sounds good. I think we'll lose the git history for those migrated 
modules, right?{quote}
Here's how we can keep history:
{noformat}
git clone https://github.com/julianhyde/optiq.git
git subtree add --prefix=linq4j https://github.com/julianhyde/linq4j.git master
git subtree add --prefix=example-csv 
https://github.com/julianhyde/optiq-csv.git master
{noformat}

Here's the result: 
https://github.com/vlsi/optiq-tmp/blame/retired/linq4j/src/main/java/net/hydromatic/linq4j/AbstractEnumerable.java

This becomes unusual git tree (with multiple roots), however that is exactly 
what we want if we need history.
Bonus point: I guess after-the-fact pull requests from linq4j and optiq-csv are 
possible as well, however that is not a priority.

I often use commit history/blame in IDE to get familiar with the code. For 
instance, it enables you to link test-case with the required changes that made 
test work.

> Re-organize package structure
> -----------------------------
>
>                 Key: OPTIQ-296
>                 URL: https://issues.apache.org/jira/browse/OPTIQ-296
>             Project: Optiq
>          Issue Type: Bug
>            Reporter: GitHub Import
>              Labels: github-import
>
> As we move code to the `org.apache.optiq` namespace, there is an opportunity 
> to re-organize the package structure of the code.
> Proposed new structure is <a 
> href="https://docs.google.com/spreadsheets/d/1SdLgVh0Zxdk-Hz4mVC7lgzNFFMI5InXu2lsqCh7upeo/edit?usp=sharing";>in
>  a spreadsheet</a>.
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/julianhyde/optiq/issues/296
> Created by: [julianhyde|https://github.com/julianhyde]
> Labels: 
> Created at: Thu May 29 21:09:56 CEST 2014
> State: open



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to