Github user dain commented on a diff in the pull request:
https://github.com/apache/orc/pull/132#discussion_r122575252
--- Diff: java/core/src/java/org/apache/orc/impl/OrcTail.java ---
@@ -70,8 +70,11 @@ public long getFileModificationTime() {
public OrcFile.WriterVersion getWriterVersion() {
OrcProto.PostScript ps = fileTail.getPostscript();
+ OrcProto.Footer footer = fileTail.getFooter();
+ OrcFile.WriterImplementation writer =
+ OrcFile.WriterImplementation.from(footer.getWriter());
return (ps.hasWriterVersion()
--- End diff --
I suggest we make `writerVersion` required for the new writer
implementations, so you would just throw in that case... This is similar to
the reason we are starting with writer version 6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
