Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131738380
--- Diff: c++/include/orc/Common.hh ---
@@ -27,6 +27,30 @@
#include <string>
namespace orc {
+
+ class FileVersion {
--- End diff --
You should have 2 instance values for HIVE_0_11 and HIVE_0_12. With the
current implementation, you'll need to throw if they use anything but
HIVE_0_11, since that corresponds to RLEv1. We'll also need to have
Reader.getFormatVersion() return this type too, but that can be done later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
