Github user prasanthj commented on a diff in the pull request:

    https://github.com/apache/orc/pull/154#discussion_r132804639
  
    --- Diff: java/core/src/java/org/apache/orc/impl/MemoryManagerImpl.java ---
    @@ -81,6 +81,7 @@ public Thread getOwner() {
        */
       public MemoryManagerImpl(Configuration conf) {
         double maxLoad = OrcConf.MEMORY_POOL.getDouble(conf);
    +    ROWS_BETWEEN_CHECKS = OrcConf.ROWS_BETWEEN_CHECKS.getLong(conf);
    --- End diff --
    
    validate values here? and set default value in case of invalid values and 
maybe log?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to