Github user majetideepak commented on a diff in the pull request: https://github.com/apache/orc/pull/151#discussion_r138157541 --- Diff: c++/include/orc/Reader.hh --- @@ -288,6 +288,18 @@ namespace orc { virtual uint64_t getCompressionSize() const = 0; /** + * Get ID of writer that generated the file. + * @return UNKNOWN_WRITER if the writer ID is undefined + */ + virtual WriterId getWriterId() const = 0; + + /** + * Get the writer id value when getWriterId() returns an unknown writer. + * @return the integer value of the writer ID. + */ + virtual int getUnknownWriterIdValue() const = 0; --- End diff -- Should this be `getWriteIdValue`? I think the implementation returns both known and unknown ids?
---