Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/212#discussion_r162755019
--- Diff: c++/src/RLEv1.cc ---
@@ -169,11 +169,11 @@ void RleEncoderV1::writeVslong(int64_t val) {
void RleEncoderV1::writeVulong(int64_t val) {
while (true) {
- if ((val & ~0x7f) == 0) {
+ if ((val & ~BASE_128_MASK) == 0) {
--- End diff --
I don't think we need change here as ~0x7f will be implicitly converted to
int64_t.
Same for the below.---
