Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/213#discussion_r166680089
  
    --- Diff: java/core/src/java/org/apache/orc/InMemoryKeystore.java ---
    @@ -0,0 +1,403 @@
    +package org.apache.orc;
    +
    +import org.apache.commons.lang.StringUtils;
    +import org.apache.orc.impl.HadoopShims;
    +
    +import javax.crypto.BadPaddingException;
    +import javax.crypto.Cipher;
    +import javax.crypto.IllegalBlockSizeException;
    +import javax.crypto.spec.IvParameterSpec;
    +import javax.crypto.spec.SecretKeySpec;
    +import java.io.IOException;
    +import java.security.InvalidAlgorithmParameterException;
    +import java.security.InvalidKeyException;
    +import java.security.Key;
    +import java.security.NoSuchAlgorithmException;
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.concurrent.locks.ReentrantReadWriteLock;
    +
    +/**
    --- End diff --
    
    Please move the license to the top of the file and start it with /* instead 
of /**


---

Reply via email to