[GitHub] orc pull request #233: ORC-322: [C++] Fix writing & reading timestamp

[wgtmac]

Github user wgtmac commented on a diff in the pull request:

    https://github.com/apache/orc/pull/233#discussion_r175257375
  
    --- Diff: c++/src/Vector.cc ---
    @@ -436,4 +438,8 @@ namespace orc {
               + static_cast<uint64_t>(
                   (data.capacity() + nanoseconds.capacity()) * 
sizeof(int64_t));
       }
    +
    +  int64_t TimestampVectorBatch::getSecondInWriterTZ(uint64_t rowId) {
    +    return data[rowId] + writerTimezone->getVariant(data[rowId]).gmtOffset;
    --- End diff --
    
    Good suggestion!


---