Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r176909659
--- Diff: c++/src/ColumnWriter.cc ---
@@ -1194,9 +1194,8 @@ namespace orc {
bool hasNull = false;
for (uint64_t i = 0; i < numValues; ++i) {
if (notNull == nullptr || notNull[i]) {
- // TimestampVectorBatch stores data in local timezone
- int64_t millsUTC =
- timezone.convertToUTC(secs[i]) * 1000 + nanos[i] / 1000000;
+ // TimestampVectorBatch stores data in UTC timezone
--- End diff --
Can you add a comment for TimestampVectorBatch regarding this requirement?
---
