[GitHub] orc issue #253: ORC-346: [C++] Add one second when writing negative Timestam...

[rip-nsk]

Github user rip-nsk commented on the issue:

    https://github.com/apache/orc/pull/253
  
    I'm not sure that it is correct fix, IMO, TimestampColumnReader should not 
do this:
            if (secsBuffer[i] < 0 && nanoBuffer[i] != 0) {
              secsBuffer[i] -= 1;
            }
    but it seems necessary to match the java reader.


---