Github user yuruiz commented on a diff in the pull request: https://github.com/apache/orc/pull/273#discussion_r191973999 --- Diff: c++/src/Writer.cc --- @@ -38,9 +38,10 @@ namespace orc { FileVersion fileVersion; double dictionaryKeySizeThreshold; bool enableIndex; + RleVersion rleVersion; --- End diff -- yes, please check the Writer.cc:129 setFileVersion(), we removed setRleVersion and will only update RleVersion on setting FileVersion. The reason we still keep RleVersion in WriterOptions is that there is dependency on RleVersion everywhere, removing it should be done in separate PR.
---