Github user wgtmac commented on a diff in the pull request: https://github.com/apache/orc/pull/277#discussion_r192907281 --- Diff: c++/src/TypeImpl.cc --- @@ -258,31 +258,34 @@ namespace orc { case STRUCT: { StructVectorBatch *result = new StructVectorBatch(capacity, memoryPool); + std::unique_ptr<ColumnVectorBatch> return_value = std::unique_ptr<ColumnVectorBatch>(result); --- End diff -- maybe we can directly merge line 260 and 261 to a single statement. same for below.
---