Sounds good !
On Fri, Jun 21, 2019 at 3:40 PM Owen O'Malley <[email protected]> wrote: > Sandeep, > In my opinion, I'd rather wait for a full release rather than introduce > the relatively large change back into the stable 1.5 branch. That said, we > absolutely need to get a brand new 1.6 release done as it has been more > than a year since 1.5 came out. Today, I cherry-picked ORC-366, which helps > with the tzdir setup on windows, and ORC-511, which fixes the docker files > for debian 8. > > I've been working through the patches from my orc-14 > <https://github.com/omalley/orc/tree/orc-14> branch. I've had a couple of > the patches up for a couple of weeks and then two more last week and I've > been hoping to get reviews on them, but I guess I'll go ahead and start > committing them and let the reviews come in lazily. > > On Wed, Jun 19, 2019 at 7:31 AM Sandeep Moré <[email protected]> > wrote: > > > Hello Owen, > > > > It would be nice to include ORC-203 > > <https://issues.apache.org/jira/browse/ORC-203> (Modify the > > StringStatistics to trim minimum and maximum values), > > not critical but more like good to have. If including ORC-203 the > following > > subsequent fixes will also be needed. > > > > 1. ORC-422 <https://issues.apache.org/jira/browse/ORC-422> - Predicate > > push > > down can return incorrect value when lower/upper bounds are set > > 2. ORC-438 <https://issues.apache.org/jira/browse/ORC-438> - NPE in > > StringStatisticsImpl.merge() > > 3. ORC-407 <https://issues.apache.org/jira/browse/ORC-407> - > JsonFileDump > > class needs to be updated to take into account string truncations > > > > Best, > > Sandeep > > > > On Wed, Jun 19, 2019 at 9:04 AM Owen O'Malley <[email protected]> > > wrote: > > > > > All, > > > We have some users wanting a 1.5.6. Is there anything that isn't > > > currently on branch-1.5 that anyone would like to include? > > > > > > .. Owen > > > > > >
