+1. Checked the LICENSE and NOTICE files, did a build, ran the unit tests. On the Java side did a build with a clean repo and ran RAT. (I don't know how to run RAT on the C++ side but it would be good to somehow make the same license checks.)
One small nit, the copyright date in NOTICE is way out of date (2015). I already updated it in both master and branch-1.5 so it should be fixed for future releases. Alan. On Fri, Jun 21, 2019 at 9:31 PM Owen O'Malley <[email protected]> wrote: > All, > > Should we release the following artifacts as ORC 1.5.6? > > tar: http://home.apache.org/~omalley/orc-1.5.6/ > tag: https://github.com/apache/orc/releases/tag/release-1.5.6rc1 > jiras: https://issues.apache.org/jira/projects/ORC/versions/12345170 > > Thanks! >
