omalley commented on a change in pull request #538:
URL: https://github.com/apache/orc/pull/538#discussion_r474309885
##########
File path: proto/orc_proto.proto
##########
@@ -343,7 +343,7 @@ message Encryption {
enum CalendarKind {
UNKNOWN_CALENDAR = 0;
// The Java default calendar changes from Julian to Gregorian
- // in 1583.
+ // in October 1582.
Review comment:
Java hasn't changed its behavior, we've just become more aware of it.
Does making the text "Written using the hybrid Julian/Gregorian calendar
with a cutover point in October 1582" make the intent clear?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
