omalley commented on pull request #540: URL: https://github.com/apache/orc/pull/540#issuecomment-680303799
Ok, I made a few changes as well as updating the tests. 1. I moved from LocalDate to ChronoLocalDate, which is agnostic to the Chronology (eg. Hybrid vs Proleptic). 2. The LocalDate or HybridDate returned from get(Minimum/Maximum)LocalDate depend on the calendar that is selected. 3. We handle the conversion from ChronoLocalDate to string explicitly so that don't get the chronology. We also need an update to storage-api to allow ChronoLocalDate in SARG predicates. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
