omalley commented on pull request #497: URL: https://github.com/apache/orc/pull/497#issuecomment-681195604
Sorry for the long delay on this one. I made some changes that should be looked over. I pushed my changes to my [orc-611 branch](https://github.com/omalley/orc/tree/orc-611). The main one was changing the protobuf to used unsigned ints for min & max nanos. To ensure that we don't lose the ability to detect the old files (when we move to protobuf 3), I added one to the values so that the range of both fields is 1 to 1_000_000. (Protobuf 3 doesn't serialize the default value for fields, so a 0 would not be serialized.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
