dongjoon-hyun commented on a change in pull request #543:
URL: https://github.com/apache/orc/pull/543#discussion_r511540611
##########
File path: c++/include/orc/sargs/Literal.hh
##########
@@ -63,10 +90,15 @@ namespace orc {
Literal(bool val);
/**
- * Create a literal of Timestamp or DATE type
Review comment:
This looks like a breaking change at `Literal` class. Can we create
`Timestamp` literal with `Literal(PredicateDataType type, int64_t val)` like
before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
