chaoyli commented on a change in pull request #586:
URL: https://github.com/apache/orc/pull/586#discussion_r547612574
##########
File path: c++/src/RleEncoderV2.cc
##########
@@ -577,7 +577,10 @@ void RleEncoderV2::writePatchedBasedValues(EncodingOption&
option) {
// find the number of bytes required for base and shift it by 5 bits
// to accommodate patch width. The additional bit is used to store the sign
// of the base value.
- const uint32_t baseWidth = findClosestNumBits(option.min) + 1;
+ uint32_t baseWidth = findClosestNumBits(option.min) + 1;
Review comment:
I will change it to skip the sign bit addition when the width is already
64 bits
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
