pgaref commented on pull request #586: URL: https://github.com/apache/orc/pull/586#issuecomment-758574909
> @pgaref Sorry, I have delayed this patch for days. I introduced the PatchedBase unit test to Cpp side. Thank you to review it. Hey @chaoyli -- np at all, we all have our own distractions. PR is on the right path, can you please check the failing tests on the Cpp side? I would also keep the **testBaseValueLimit** on the Java side even thought you have a similar test case -- I would just rename to something like testMaxPatchBaseValue. Thanks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
