boroknagyz commented on a change in pull request #682:
URL: https://github.com/apache/orc/pull/682#discussion_r615973103
##########
File path: c++/include/orc/Type.hh
##########
@@ -58,6 +58,11 @@ namespace orc {
virtual uint64_t getMaximumLength() const = 0;
virtual uint64_t getPrecision() const = 0;
virtual uint64_t getScale() const = 0;
+ virtual Type& setAttribute(const std::string& key,
Review comment:
This allows method chaining. I've followed the Java implementation:
https://github.com/apache/orc/blob/f381f2dd78e6b305b8a4e0b07124034de72ef1a1/java/core/src/java/org/apache/orc/TypeDescription.java#L242-L252
But I can switch to void if you prefer that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
