dongjoon-hyun commented on a change in pull request #746:
URL: https://github.com/apache/orc/pull/746#discussion_r670558826
##########
File path: java/core/src/java/org/apache/orc/TypeDescription.java
##########
@@ -50,6 +51,25 @@
public static final String ENCRYPT_ATTRIBUTE = "encrypt";
public static final String MASK_ATTRIBUTE = "mask";
+ private int id = -1;
+ private int maxId = -1;
+ private TypeDescription parent;
+ private final Category category;
+ private final List<TypeDescription> children;
+ private final List<String> fieldNames;
+ private final Map<String,String> attributes = new HashMap<>();
+ private int maxLength = DEFAULT_LENGTH;
+ private int precision = DEFAULT_PRECISION;
+ private int scale = DEFAULT_SCALE;
+
+ public TypeDescription(final Category category) {
+ this.category = Objects.requireNonNull(category);
+ this.children =
+ (category.isPrimitive) ? Collections.emptyList() : new ArrayList<>();
+ this.fieldNames = (category != Category.STRUCT) ? Collections.emptyList()
+ : new ArrayList<>();
+ }
Review comment:
Please don't relocate the position.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
