[GitHub] [orc] dongjoon-hyun opened a new pull request #793: ORC-891: Use assert methods without package name

[GitBox]

dongjoon-hyun opened a new pull request #793:
URL: https://github.com/apache/orc/pull/793


   ### What changes were proposed in this pull request?
   
   This PR aims to use `assertXXX` methods directly without their package name, 
`Assert`.
   
   ```java
   -import org.junit.Assert;
    import org.junit.Before;
    import org.junit.Test;
    
   @@ -194,12 +193,12 @@ public class TestFileDump {
          if (actualLine != null) {
            actualLine = actualLine.trim();
          }
   -      Assert.assertEquals(expectedLine, actualLine);
   +      assertEquals(expectedLine, actualLine);
   ```
   
   ### Why are the changes needed?
   
   There are two benefits after this PR.
   - It's easy to remove the JUnit5 `vintage` engine and migrate to the real 
JUnit5.
   - It reduces the length of lines. We are gradually reducing the maximum 
limit of length by the checkstyle rule to 80 which is [the ORC coding 
guideline](https://orc.apache.org/develop/coding/).
   
   ### How was this patch tested?
   
   Pass the CIs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org