[GitHub] [orc] dongjoon-hyun commented on a change in pull request #838: ORC-925: Simplify Assertions

[GitBox]

dongjoon-hyun commented on a change in pull request #838:
URL: https://github.com/apache/orc/pull/838#discussion_r684996028



##########
File path: java/core/src/findbugs/exclude.xml
##########
@@ -56,4 +56,44 @@
     <Class name="org.apache.orc.TypeDescription"/>
     <Method name="equals" />
   </Match>
+  <Match>
+    <Bug pattern="NP_NULL_ON_SOME_PATH"/>
+    <Class name="org.apache.orc.impl.StreamName"/>
+    <Method name="compareTo" />
+  </Match>
+  <Match>
+    <Bug pattern="NP_NULL_ON_SOME_PATH"/>
+    <Class name="org.apache.orc.impl.reader.ReaderEncryptionKey"/>
+    <Method name="compareTo" />
+  </Match>
+  <Match>
+    <Bug pattern="NP_NULL_ON_SOME_PATH"/>
+    <Class name="org.apache.orc.impl.reader.ReaderEncryptionVariant"/>
+    <Method name="compareTo" />
+  </Match>
+  <Match>
+    <Bug pattern="NP_NULL_ON_SOME_PATH"/>
+    <Class name="org.apache.orc.impl.MaskDescriptionImpl"/>
+    <Method name="compareTo" />
+  </Match>
+  <Match>
+    <Bug pattern="NP_NULL_ON_SOME_PATH"/>
+    <Class name="org.apache.orc.impl.TreeReaderFactory$TreeReader"/>
+    <Method name="&lt;init&gt;" />
+  </Match>
+  <Match>
+    <Bug pattern="NP_NULL_ON_SOME_PATH"/>
+    <Class name="org.apache.orc.impl.writer.WriterEncryptionKey"/>
+    <Method name="compareTo" />
+  </Match>
+  <Match>
+    <Bug pattern="NP_NULL_ON_SOME_PATH"/>
+    <Class name="org.apache.orc.impl.writer.WriterEncryptionVariant"/>
+    <Method name="compareTo" />
+  </Match>
+  <Match>
+    <Bug pattern="NP_NULL_PARAM_DEREF"/>
+    <Class name="org.apache.orc.impl.reader.StripePlanner"/>
+    <Method name="planPartialDataReading" />
+  </Match>

Review comment:
       Got it. I remember that `findbugs` was confused before in the similar 
way. For this one, it looks like due to `JetBrain` NotNull annotation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org