dongjoon-hyun commented on a change in pull request #903:
URL: https://github.com/apache/orc/pull/903#discussion_r704032816
##########
File path: c++/src/Reader.cc
##########
@@ -385,7 +385,7 @@ namespace orc {
void RowReaderImpl::seekToRowGroup(uint32_t rowGroupEntryId) {
// store positions for selected columns
- std::vector<std::list<uint64_t>> positions;
+ std::list<std::list<uint64_t>> positions;
Review comment:
Could you elaborate a little more about your PR description?
> Reallocation of positions vector may invalidate contained iterators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
