wgtmac commented on pull request #921:
URL: https://github.com/apache/orc/pull/921#issuecomment-931023274


   > Currently the other tools (orc-contents and orc-memory) that support 
specifying columns use fieldId instead of columnId. So only top-level field ids 
are supported. The new option in orc-scan has the same meaning as these tools. 
I'd suggest adding another option, e.g. --columnIds=1,2,3, for specifying 
columnIds. Maybe in a separate PR. Do you think it's ok?
   > 
   > BTW, I slightly modify the test to include a top-level STRUCT column 
(fieldId=9 in examples/TestOrcFile.testSeek.orc).
   
   I am OK with the current PR (i.e. column selection by the field ids). The 
orc-scan tool is usually used to verify the integrity of an ORC file. We can 
add more complex column selection option to it later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to