guiyanakuang edited a comment on pull request #930: URL: https://github.com/apache/orc/pull/930#issuecomment-935312527
> Thank you for making a PR, @guiyanakuang . BTW, this looks like a revert of [ORC-807](https://issues.apache.org/jira/browse/ORC-807) (from @belugabehr ) > > So, is this the current status, @guiyanakuang ? > > > In fact, the bench module does not directly depend on jackson, only spark indirectly depends on the specified version of jackson. Yes, because the code that depends on jackson has been rewritten with gson in ORC-946. I'm sure this is the current state. > Comment before update: which reminds me that we don't even need to declare Spark's dependency on jackson, there is no conflict. > I immediately made a new commit to remove the explicit dependency of spark on jackson. update: I was wrong, actually spark and avro depend on different versions of jackson, explicit dependencies are better than letting maven choose based on the length of the dependency path, I think it's better to keep it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
