dongjoon-hyun commented on a change in pull request #936:
URL: https://github.com/apache/orc/pull/936#discussion_r727582243
##########
File path: java/core/src/java/org/apache/orc/impl/filter/FilterFactory.java
##########
@@ -46,16 +49,35 @@
* @param isSchemaCaseAware identifies if the schema is case-sensitive
* @param version provides the ORC file version
* @param normalize identifies if the SArg should be normalized or
not
+ * @param filePath that is fully qualified to determine plugin filter(s)
+ * @param conf configuration shared when determining Plugin filter(s)
Review comment:
Could you align these new parameters with the other existing ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
