guiyanakuang commented on a change in pull request #940:
URL: https://github.com/apache/orc/pull/940#discussion_r732474540



##########
File path: java/core/src/test/org/apache/orc/impl/TestEncryption.java
##########
@@ -140,4 +145,43 @@ public void testPushDownReadEncryption() throws 
IOException {
     read(true);
   }
 
+  @Test
+  @SuppressWarnings("unchecked")
+  public void testConcurrentCreation() throws InterruptedException {

Review comment:
       Although the ServiceLoader is not thread-safe, there is a chance that 
concurrent access will work, so I'll investigate if there's a better way to 
reproduce it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to