guiyanakuang commented on a change in pull request #941:
URL: https://github.com/apache/orc/pull/941#discussion_r736333556
##########
File path: java/tools/pom.xml
##########
@@ -91,6 +91,12 @@
<artifactId>junit-jupiter-api</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>commons-io</groupId>
+ <artifactId>commons-io</artifactId>
Review comment:
`assertTrue(FileUtils.contentEquals(new File(testFilePathStr), new
File(copyTestFilePathStr)));`
The main reason is to use the file content comparison, because I found that
the getFileChecksum method only gets null for the local file system. So I'll
add a private method for file content comparison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
