coderex2522 commented on a change in pull request #975:
URL: https://github.com/apache/orc/pull/975#discussion_r776603215
##########
File path: tools/test/TestCSVFileImport.cc
##########
@@ -53,3 +53,27 @@ TEST (TestCSVFileImport, test10rows) {
EXPECT_EQ(expected, output);
EXPECT_EQ("", error);
}
+
+TEST (TestCSVFileImport, testTimezoneOption) {
+ // create an ORC file from importing the CSV file
+ const std::string pgm1 = findProgram("tools/src/csv-import");
+ const std::string csvFile =
+ findExample("TestCSVFileImport.testTimezoneOption.csv");
+ const std::string orcFile = "/tmp/test_csv_import_test_timezone_option.orc";
+ const std::string schema = "'struct<_a:timestamp>'";
+ std::string output;
+ std::string error;
+
+ std::string option = "--timezone=America/Los_Angeles";
Review comment:
If we don't set timezone for the WriterOptions, the writer will write
the timestamp with the GMT timezone. And the orc-contents tool will scan the
content in the GMT timezone.This case should not be successful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
