rizaon commented on a change in pull request #990:
URL: https://github.com/apache/orc/pull/990#discussion_r779218710
##########
File path: c++/src/Reader.cc
##########
@@ -290,6 +291,15 @@ namespace orc {
return selectedColumns;
}
+ ArrayReadIntent RowReaderImpl::getReadIntent(uint64_t typeId) const {
+ auto elem = readIntents.find(typeId);
+ if (elem == readIntents.end()) {
+ return ArrayReadIntent_ALL;
+ } else {
+ return elem->second;
Review comment:
The TestColumnReaderEncoded.testListOffsetsOnly that I add only mock up
to StripeStreamsImpl::getReadIntent(), and I believe it didn't touch this part.
I will try to add more comprehensive tests. Do you know any existing unit
tests I can refer to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
