guiyanakuang commented on pull request #1003:
URL: https://github.com/apache/orc/pull/1003#issuecomment-1008501054
> Thanks. Could you elaborate how to verify your PR in the PR description,
@guiyanakuang ?
@dongjoon-hyun This can be tested with the following code
```java
@Test
public void test() {
OrcProto.RowIndexEntry entry =
OrcProto.RowIndexEntry.newBuilder().addPositions(0).build();
assertFalse(entry.hasStatistics());
assertNotNull(entry.getStatistics());
}
```
But since this is just testing Protobuf generated code, I'm not sure if I
should add it to the unit tests.
On the other hand, our proto is defined as follows, statistics is optional
https://github.com/apache/orc/blob/7d2838b4b38111bc1bfa00592d84a8b36286b9f2/proto/orc_proto.proto#L102-L105
Our orc writer implementation, however, will definitely write statistics,
and there is no optional configuration, so it cannot be verified by the files
written by orc
https://github.com/apache/orc/blob/7d2838b4b38111bc1bfa00592d84a8b36286b9f2/java/core/src/java/org/apache/orc/impl/writer/TreeWriterBase.java#L322-L330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
