guiyanakuang opened a new pull request #1009:
URL: https://github.com/apache/orc/pull/1009
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
This pr aims to add test cases specifically to check that writers support
the selected vector feature.
`testWriteBaseTypeUseSelectedVector`: For covering base types.
`testWriteComplexTypeUseSelectedVector`: For covering multiple nested types.
`testWriteRepeatedUseSelectedVector`: For covering repeated values.
`testWriteEncryptionUseSelectedVector`: For covering field encryption.
Test the idea that the value written to one field is associated with the row
number and that the other fields are obtained by some transformation of the
value of this field. The feature is guaranteed to be correct by checking the
selected row number against the read result.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Enrich test cases to ensure robustness of feature.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
Pass the commit test cases. Currently marked as disabled first until
https://github.com/apache/orc/pull/994/files merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
