zhanglistar commented on a change in pull request #1010:
URL: https://github.com/apache/orc/pull/1010#discussion_r785592742
##########
File path: cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -74,7 +74,7 @@ else ()
set(SNAPPY_INCLUDE_DIR "${SNAPPY_HOME}/include")
set(SNAPPY_STATIC_LIB
"${SNAPPY_HOME}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}snappy${CMAKE_STATIC_LIBRARY_SUFFIX}")
set(SNAPPY_CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${SNAPPY_HOME}
- -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_LIBDIR=lib)
+ -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_LIBDIR=lib
-DSNAPPY_BUILD_TESTS=OFF)
Review comment:
>
It is also failure in gcc-9. The whole link message is in
file([snappy_ep-build-err.log](https://github.com/apache/orc/files/7878515/snappy_ep-build-err.log)
). I think it is the linker that can not find gtest lib which I did not
install. So It it better not compile the snappy unit test because we just use
it not develop it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
