stiga-huang commented on a change in pull request #1008:
URL: https://github.com/apache/orc/pull/1008#discussion_r785611327
##########
File path: c++/src/Compression.cc
##########
@@ -533,24 +545,37 @@ DIAGNOSTIC_PUSH
}
/** There are three possible scenarios when seeking a position:
- * 1. The seeked position is already read and decompressed into
- * the output stream.
- * 2. It is already read from the input stream, but has not been
- * decompressed yet, ie. it's not in the output stream.
- * 3. It is not read yet from the inputstream.
+ * 1. The chunk of the seeked position is already read and decompressed into
the output
+ * stream, ie. chunk header is read and chunk contents are in the output
stream.
+ * 2. The chunk of the seeked position is partially read. This only happens
for
+ * uncompressed chunks. The chunk header is read but the seeked position
hasn't been
+ * read yet.
+ * 3. It is already read from the input stream, but has not been
decompressed yet, ie.
+ * it's not in the output stream.
+ * 4. It is not read yet from the input stream.
*/
void DecompressionStream::seek(PositionProvider& position) {
size_t seekedPosition = position.current();
Review comment:
Yeah, this confused me too. I renamed it to `seekedHeaderPosition` so
it's similar to `headerPosition`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
