dongjoon-hyun commented on a change in pull request #1023:
URL: https://github.com/apache/orc/pull/1023#discussion_r793003942
##########
File path: c++/src/TypeImpl.cc
##########
@@ -454,6 +454,7 @@ namespace orc {
throw ParseError("Illegal MAP type that doesn't contain two subtypes");
if (type.kind() == proto::Type_Kind_UNION && type.subtypes_size() == 0)
throw ParseError("Illegal UNION type that doesn't contain any
subtypes");
+
Review comment:
We usually don't mix the bug fix and a style fix in a single PR. Please
remove this redundant style change from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
