guiyanakuang commented on a change in pull request #1025:
URL: https://github.com/apache/orc/pull/1025#discussion_r803387886
##########
File path: java/tools/src/java/org/apache/orc/tools/convert/JsonReader.java
##########
@@ -333,15 +364,20 @@ public JsonReader(Reader reader,
FSDataInputStream underlying,
long size,
TypeDescription schema,
- String timestampFormat) throws IOException {
- this(new JsonStreamParser(reader), underlying, size, schema,
timestampFormat);
+ String timestampFormat,
+ String unionTag,
+ String unionValue) throws IOException {
+ this(new JsonStreamParser(reader), underlying, size, schema,
timestampFormat, unionTag,
+ unionValue);
}
public JsonReader(Iterator<JsonElement> parser,
FSDataInputStream underlying,
long size,
TypeDescription schema,
- String timestampFormat) throws IOException {
+ String timestampFormat,
+ String unionTag,
+ String unionValue) throws IOException {
Review comment:
@rizaon. Should the original constructor be retained so that the code
that already exists can be seamlessly compatible looks better. I suggest adding
a new constructor to handle the case of specifying unionTag/unionValue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
