pgaref commented on a change in pull request #1055:
URL: https://github.com/apache/orc/pull/1055#discussion_r819900799



##########
File path: java/core/src/java/org/apache/orc/impl/SchemaEvolution.java
##########
@@ -126,6 +128,11 @@ public SchemaEvolution(TypeDescription fileSchema,
       }
     }
     buildConversion(fileSchema, this.readerSchema, positionalLevels);

Review comment:
       I believe this File to Reader id mapping should be part of 
buildConversion 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to