pavibhai commented on a change in pull request #1072:
URL: https://github.com/apache/orc/pull/1072#discussion_r839799328
##########
File path: java/core/src/java/org/apache/orc/impl/BufferChunk.java
##########
@@ -89,7 +89,10 @@ public boolean equals(Object other) {
return false;
}
BufferChunk ob = (BufferChunk) other;
- return chunk.equals(ob.chunk);
+ return (chunk != null && ob.chunk != null && chunk.equals(ob.chunk))
+ || (chunk == null && ob.chunk == null
+ && offset == ob.offset
+ && getLength() == ob.getLength());
Review comment:
@dongjoon-hyun I have reverted this and included this comparison logic
in the unit test.
IMO it is more thorough to check for offset and length in the equals. We can
take that up independent of this patch.
@omalley or @pgaref any thoughts on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
