coderex2522 commented on PR #1073: URL: https://github.com/apache/orc/pull/1073#issuecomment-1096866236
> Sorry to be late here. The changes LGTM. I just have some ideas for improvements. But they should not be the blocker. We can do them in a follow-up PR. > > BTW, can we add some end-to-end tests in TestPredicatePushdown.cc? It helps to verify the changes in Reader.cc. Sure, I add the new testStripeAndFileStats UT in TestPredicatePushdown.cc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
