[GitHub] [orc] pavibhai commented on a diff in pull request #1072: ORC-1138 Optimizes the read of streams in ORC by combining multiple nearby reads into a single read, optionally allowing the retention or drop of the extra bytes

[GitBox]

pavibhai commented on code in PR #1072:
URL: https://github.com/apache/orc/pull/1072#discussion_r850882242


##########
java/core/src/java/org/apache/orc/impl/RecordReaderUtils.java:
##########
@@ -405,72 +410,31 @@ static void zeroCopyReadRanges(FSDataInputStream file,
     }
   }
 
-  /**
-   * Read the data from the file based on a list of ranges in a single read.
-   * @param file the file to read from
-   * @param first the first range to read
-   * @param last the last range to read
-   * @param allocateDirect should we use direct buffers
-   */
-  static void readRanges(FSDataInputStream file,

Review Comment:
   So you are recommending that any member that is not private should be 
assumed to be public? Is that correct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org