noirello commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851760919
##########
c++/src/ColumnWriter.cc:
##########
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] * 1000 + nanos[i] / 1000000;
if (!isUTC) {
- millsUTC = timezone.convertToUTC(millsUTC);
+ millsUTC = timezone.convertToUTC(secs[i]) * 1000 + nanos[i] /
1000000;
Review Comment:
Please, double check the timestamps in the test cases. Time zones always can
be confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
