Thank you, Pavan and everyone. Could you conclude this vote, William?
Dongjoon. On Thu, Jan 19, 2023 at 7:44 AM Pavan Lanka <pla...@apple.com.invalid> wrote: > Thanks @Dongjoon for the clarification. > > +1 for the release > > * Test the java build and tests using OpenJDK 11 > * Reviewed the list of issues > > > On Jan 18, 2023, at 9:42 PM, Dongjoon Hyun <dongjoon.h...@gmail.com> > wrote: > > > > In the previous email, the following was a typo. 1.8.2 and 1.7.9 are the > > correct versions which I wanted to mention. > > ``` > > - Implementing is not the scope of urgent 1.8.1 and 1.7.7 releases. > > + Implementing is not the scope of urgent 1.8.2 and 1.7.9 releases. > > ``` > > > > > > On Wed, Jan 18, 2023 at 9:29 PM Dongjoon Hyun <dongjoon.h...@gmail.com> > > wrote: > > > >> Thank you, Pavan. > >> > >> 1. Yes, it's intentional. First, we cannot remove the added public API. > >> That's the main reason why we couldn't revert the commit physically. > This > >> discussion happended on the original PR. Second, we keep the added test > >> case by marking 'ignored' because we want to re-enable the test case > when > >> the feature is ready later. > >> > >> 2. Yes, right. Implementing is not the scope of urgent 1.8.1 and 1.7.7 > >> releases. It's not s blocker for these releases because there is no > reader > >> implementation before. We are open for implementng that missing > features in > >> new releases. Feel free to make a PR if you are interested. > >> > >> Dongjoon > >> > >> On Wed, Jan 18, 2023 at 8:30 PM Pavan Lanka <pla...@apple.com.invalid> > >> wrote: > >> > >>> I wanted to follow up on ORC-1343 (Ignore orc.create.index). > >>> * The discussion in the Jira seems to indicate that we want to revert > >>> ORC-1283, but the included changes are not a full revert, was that > >>> intentional? > >>> * I think any files created with the previous version of the writer > with > >>> index as false and row_index_stride > 0 will continue to fail during > read, > >>> didn’t we need to fix that? I do see that the scope is limited with > >>> ORC-1283 coming in to 1.7.7 and 1.8.1 > >>> > >>> Please clarify. > >>> > >>> Thanks, > >>> Pavan > >>> > >>>> On Jan 16, 2023, at 1:47 PM, William H. <williamhy...@gmail.com> > wrote: > >>>> > >>>> Please vote on releasing the following candidate as Apache ORC version > >>> 1.7.8. > >>>> > >>>> [ ] +1 Release this package as Apache ORC 1.7.8 > >>>> [ ] -1 Do not release this package because ... > >>>> > >>>> TAG: > >>>> https://github.com/apache/orc/releases/tag/v1.7.8-rc0 > >>>> > >>>> RELEASE FILES: > >>>> https://dist.apache.org/repos/dist/dev/orc/v1.7.8-rc0 > >>>> > >>>> STAGING REPOSITORY: > >>>> https://repository.apache.org/content/repositories/orgapacheorc-1065 > >>>> > >>>> LIST OF ISSUES: > >>>> https://issues.apache.org/jira/projects/ORC/versions/12352724 > >>>> https://github.com/apache/orc/milestone/14 > >>>> > >>>> This vote will be open for 72 hours. > >>>> > >>>> Regards, > >>>> William > >>> > >>> > >
