+1 - Build and test C++/Java on macOS (intel) 13.4.1 with Apple clang 14.0.3 and openjdk 11.0.19 - Verified checksum and signature
Bests, Yiqun Shaoyun Chen <c...@apache.org> 于2023年6月25日周日 16:23写道： > +1 > > Both use Apple Clang version 14.0.3[1] and Clang 14.0.6[2] installed > through brew can build successfully. > > [1] https://github.com/apache/orc/pull/1551#issuecomment-1605893531 > [2] https://github.com/apache/orc/pull/1551#issuecomment-1605920181 > > Gang Wu <ust...@gmail.com> 于2023年6月25日周日 16:14写道： > > > > +1 > > > > After I tried to enforce clang 14 via env, everything looks good now. > > If we are not dropping support of clang 13 or under, we still need > > the fix above. > > > > Best, > > Gang > > > > On Sun, Jun 25, 2023 at 12:02 PM Gang Wu <ust...@gmail.com> wrote: > > > > > I use clang 14 on my mac m1. > > > > > > ➜ clang -v > > > Homebrew clang version 14.0.6 > > > Target: arm64-apple-darwin21.6.0 > > > Thread model: posix > > > InstalledDir: /opt/homebrew/opt/llvm@14/bin > > > > > > I think the issue can only happen on non-x86 machines. > > > This is the proposed fix: https://github.com/apache/orc/pull/1552 > > > > > > Best regards > > > Gang > > > > > > > > > > > > On Sun, Jun 25, 2023 at 11:54 AM Dongjoon Hyun < > dongjoon.h...@gmail.com> > > > wrote: > > > > > >> Thank you for testing and sharing. > > >> > > >> What is your environment? From 1.9, all docker environements are > moved to > > >> at least Clang 14+. > > >> > > >> Dongjoon > > >> > > >> On Sat, Jun 24, 2023 at 6:40 PM Gang Wu <ust...@gmail.com> wrote: > > >> > > >> > Thanks Dongjoon! > > >> > > > >> > I have verified checksum and signature. And also can confirm that > the > > >> java > > >> > build works as expected. > > >> > > > >> > However, when I tried to run the C++ build, it complains with > following > > >> > error: > > >> > > > >> > [ 46%] Building CXX object c++/src/CMakeFiles/orc.dir/Common.cc.o > > >> > [ 47%] Building CXX object > c++/src/CMakeFiles/orc.dir/Compression.cc.o > > >> > [ 48%] Building CXX object > > >> > c++/src/CMakeFiles/orc.dir/ConvertColumnReader.cc.o > > >> > [ 48%] Building CXX object > c++/src/CMakeFiles/orc.dir/CpuInfoUtil.cc.o > > >> > [ 49%] Building CXX object > c++/src/CMakeFiles/orc.dir/Exceptions.cc.o > > >> > [ 49%] Building CXX object c++/src/CMakeFiles/orc.dir/Int128.cc.o > > >> > [ 50%] Building CXX object > > >> c++/src/CMakeFiles/orc.dir/LzoDecompressor.cc.o > > >> > /Users/gangwu/RC/ > > >> > > > >> > > > >> > dist.apache.org/repos/dist/dev/orc/v1.9.0-rc0/orc-1.9.0/c++/src/CpuInfoUtil.cc:65:9 > > >> > : > > >> > error: macro is not used [-Werror,-Wunused-macros] > > >> > #define UNUSED(x) (void)(x) > > >> > ^ > > >> > 1 error generated. > > >> > make[2]: *** [c++/src/CMakeFiles/orc.dir/CpuInfoUtil.cc.o] Error 1 > > >> > make[2]: *** Waiting for unfinished jobs.... > > >> > make[1]: *** [c++/src/CMakeFiles/orc.dir/all] Error 2 > > >> > make: *** [all] Error 2 > > >> > > > >> > Let me investigate and update with a fix. > > >> > > > >> > Best, > > >> > Gang > > >> > > > >> > On Sat, Jun 24, 2023 at 3:23 PM Dongjoon Hyun < > dongjoon.h...@gmail.com> > > >> > wrote: > > >> > > > >> > > I'll start with my +1. > > >> > > > > >> > > RC0 is tested with all test coverages including unit tests, > multiple > > >> > docker > > >> > > os tests, Spark and Iceberg integration tests. Here is the > summary. > > >> > > > > >> > > https://github.com/apache/orc/issues/1532 > > >> > > > > >> > > Dongjoon. > > >> > > > > >> > > > > >> > > > > >> > > On Fri, Jun 23, 2023 at 5:47 PM Dongjoon Hyun < > dongj...@apache.org> > > >> > wrote: > > >> > > > > >> > > > Please vote on releasing the following candidate as Apache ORC > > >> version > > >> > > > 1.9.0. This vote is open until June 28th 1AM (PST) and passes > if a > > >> > > majority > > >> > > > +1 PMC votes are cast, with a minimum of 3 +1 votes. > > >> > > > > > >> > > > [ ] +1 Release this package as Apache ORC 1.9.0 > > >> > > > [ ] -1 Do not release this package because ... > > >> > > > > > >> > > > TAG: > > >> > > > https://github.com/apache/orc/releases/tag/v1.9.0-rc0 > > >> > > > > > >> > > > RELEASE FILES: > > >> > > > https://dist.apache.org/repos/dist/dev/orc/v1.9.0-rc0 > > >> > > > > > >> > > > STAGING REPOSITORY: > > >> > > > > > >> https://repository.apache.org/content/repositories/orgapacheorc-1070 > > >> > > > > > >> > > > LIST OF ISSUES: > > >> > > > https://issues.apache.org/jira/projects/ORC/versions/12351711 > > >> > > > https://github.com/apache/orc/milestone/10?closed=1 > > >> > > > > > >> > > > > > >> > > > Thanks, > > >> > > > Dongjoon. > > >> > > > > > >> > > > > >> > > > >> > > > >
