+1 (non-binding)
I checked the following things:
- signatures are good.
```
gpg --verify orc-1.8.7.tar.gz.asc
```
- checksums are good.
```
sha256sum --check orc-1.8.7.tar.gz.sha256
```
- build and test success from source code.
```
make test-out
Test project /tmp/orc-1.8.7/orc-1.8.7/build
Start 1: orc-test
1/8 Test #1: orc-test ......................... Passed 4.36 sec
Start 2: java-test
2/8 Test #2: java-test ........................ Passed 117.78 sec
Start 3: java-tools-test
3/8 Test #3: java-tools-test .................. Passed 0.09 sec
Start 4: java-bench-gen-test
4/8 Test #4: java-bench-gen-test .............. Passed 1.78 sec
Start 5: java-bench-scan-test
5/8 Test #5: java-bench-scan-test ............. Passed 1.14 sec
Start 6: java-bench-hive-test
6/8 Test #6: java-bench-hive-test ............. Passed 11.58 sec
Start 7: java-bench-spark-test
7/8 Test #7: java-bench-spark-test ............ Passed 215.39 sec
Start 8: tool-test
8/8 Test #8: tool-test ........................ Passed 11.91 sec
100% tests passed, 0 tests failed out of 8
Total Test time (real) = 364.04 sec
Built target test-out
```
```
java -version
openjdk version "1.8.0_362"
OpenJDK Runtime Environment (Zulu 8.68.0.21-CA-macos-aarch64) (build
1.8.0_362-b09)
OpenJDK 64-Bit Server VM (Zulu 8.68.0.21-CA-macos-aarch64) (build
25.362-b09, mixed mode)
```
Gang Wu <ust...@gmail.com> 于2024年4月11日周四 09:45写道：
>
> +1
>
> I've seen this issue:
> https://github.com/apache/orc/commit/9627a24439099046078c9f300028b79ab27fe33e
> and have to manually port this patch to make the build pass. Not sure if
> this is a blocker or just a special case
> of toolchain setup. So I'll give a +1 for now.
>
>
> Test project /Users/gangwu/RC/
> dist.apache.org/repos/dist/dev/orc/v1.8.7-rc0/orc-1.8.7/build
> Start 1: orc-test
> 1/8 Test #1: orc-test ......................... Passed 7.63 sec
> Start 2: java-test
> 2/8 Test #2: java-test ........................ Passed 135.10 sec
> Start 3: java-tools-test
> 3/8 Test #3: java-tools-test .................. Passed 0.10 sec
> Start 4: java-bench-gen-test
> 4/8 Test #4: java-bench-gen-test .............. Passed 1.92 sec
> Start 5: java-bench-scan-test
> 5/8 Test #5: java-bench-scan-test ............. Passed 1.19 sec
> Start 6: java-bench-hive-test
> 6/8 Test #6: java-bench-hive-test ............. Passed 11.27 sec
> Start 7: java-bench-spark-test
> 7/8 Test #7: java-bench-spark-test ............ Passed 215.06 sec
> Start 8: tool-test
> 8/8 Test #8: tool-test ........................ Passed 17.01 sec
>
> 100% tests passed, 0 tests failed out of 8
>
> Total Test time (real) = 389.31 sec
> Built target test-out
>
> C++:
> Homebrew clang version 17.0.6
> Target: arm64-apple-darwin21.6.0
> Thread model: posix
> InstalledDir: /opt/homebrew/Cellar/llvm/17.0.6_1/bin
>
> Java:
> openjdk version "1.8.0_322"
> OpenJDK Runtime Environment (Zulu 8.60.0.21-CA-macos-aarch64) (build
> 1.8.0_322-b06)
> OpenJDK 64-Bit Server VM (Zulu 8.60.0.21-CA-macos-aarch64) (build
> 25.322-b06, mixed mode)
>
>
> Best,
> Gang
>
> On Thu, Apr 11, 2024 at 5:03 AM Dongjoon Hyun <dongj...@apache.org> wrote:
>
> > +1
> >
> > Here is the release manager verification link.
> > - https://github.com/apache/orc/issues/1887
> >
> > In short,
> > - Checked checksum and GPG signature
> > - All tests (unit and docker) passed.
> > - Spark Integration tests passed with Apache Spark 3.4 branch
> > - Iceberg Integration tests passed with Apache Iceberg 1.3.x branch
> >
> > Dongjoon.
> >
> > On 2024/04/10 18:49:11 Dongjoon Hyun wrote:
> > > Please vote on releasing the following candidate as Apache ORC version
> > > 1.8.7. This vote is open until April 14th 1AM (PST) and passes if a
> > > majority +1 PMC votes are cast, with a minimum of 3 +1 votes.
> > >
> > > [ ] +1 Release this package as Apache ORC 1.8.7
> > > [ ] -1 Do not release this package because ...
> > >
> > > TAG:
> > > https://github.com/apache/orc/releases/tag/v1.8.7-rc0
> > >
> > > RELEASE FILES:
> > > https://dist.apache.org/repos/dist/dev/orc/v1.8.7-rc0
> > >
> > > STAGING REPOSITORY:
> > > https://repository.apache.org/content/repositories/orgapacheorc-1079
> > >
> > > LIST OF ISSUES:
> > > https://issues.apache.org/jira/projects/ORC/versions/12353962
> > > https://github.com/apache/orc/milestone/26?closed=1
> > >
> > > Thanks,
> > > Dongjoon.
> > >
> >
