I just got pylint installed properly (I think) and managed to run it over (hopefully) all of Chandler. It found quite a bit to complain :)
I posted the log here: https://bugzilla.osafoundation.org/attachment.cgi?id=994&action=view (bug 1824). It would be great if you could go and check areas of code you are in charge of and check whether or not those reported problems are real. Some words of warning: Think about the report before changing anything. If you think the report is correct and you make a change, run Chandler and tests to make sure the code was not relying on some side effect PyLint did not notice. For example, I've personally removed an import because PyLint said it was unused. Well, it was unused in that file, but some other file expected it. Mixin classes and some other kinds of trickery can also confuse PyLint giving errors for perfectly working stuff. Oh, and it doesn't seem to understand lambdas or decorators (probably some other features as well), so it will complain about those. Still, having said all that, just a cursory look at the warnings seems to show plenty of genuine stuff like unused imports and variables, bad indents, using undefined variables, and so forth. Oh, and if you use Eclipse and the pydev plugin, you can make it automatically give you those warnings for the files you are editing. -- Heikki Toivonen
signature.asc
Description: OpenPGP digital signature
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ Open Source Applications Foundation "Dev" mailing list http://lists.osafoundation.org/mailman/listinfo/dev
