Ted Leung wrote:
One of the items is to move away from use of onValueChanged and go  back to using constructors for creating various collection kinds.   Unfortunately, this
means that we wouldn't be able to use update to change existing  instances in the repository. 

As I recall, the issue around this was that if we marked an attribute as "readonly" then there wasn't an obvious way to actually initialize that attribute. If Andi can give us a way to initialize the attribute, and tell Phillip about it so he can make the schema stuff initialize correctly, then can't we make 'sources' be readonly?

Also, I just today noticed InclusionExclusionCollection's 'setup' method. I'm curious why some of this stuff can't be just set in the constructor? I think this is kind of tied up in this onValueChanged/readonly sources issue, which is why I bring it up. I'm hoping maybe pje will have some brilliant idea how to get rid of 'setup' because it kind of breaks our model of just using 'update' to initialize and create items.

 If nobody else has seen this method, please scroll down to the bottom of:
http://svn.osafoundation.org/chandler/trunk/chandler/parcels/osaf/pim/collections.py

Further, there was some discussion about how collections.py has references to trash folders and such. I'd like to propose that we go ahead with the class we've thrown around a bit, called 'UserCollection' or whatever we're going to call it, make it derive from InclusionExclusionCollection, and use THAT in the sidebar. That would be a perfect place to put chandler-specific behavior like the Trash.

Alec

So we can't remove the onValueChanged  stuff, so it  doesn't
make sense to duplicate the code in the collection item  constructors.  So I'm just going to leave the code the way that it is  now.

Ted



_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

Open Source Applications Foundation "Dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/dev

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

Open Source Applications Foundation "Dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/dev

Reply via email to